Skip to content

Conversation

akrennmair
Copy link

The default label in this method serves no purpose, but causes the loop to needlessly spin, wasting lots of CPU. Removing the default label fixes this behaviour without changing the functionality of the loop itself.

@knarz
Copy link
Contributor

knarz commented Nov 7, 2017

Without the default case in the receiver, the select would block until the done channel is closed and never read any messages.

@jvatianou-connamara
Copy link
Contributor

adding this to review/qa pipeline for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants