Skip to content

Conversation

stevenroose
Copy link

Solves #49

Copy link
Contributor

@erubboli-bfx erubboli-bfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, good idea

@jayme-github
Copy link

What do you think of going one step further adding an interface for HTTPClient so one can use wrapped http.Client's (handling retries, exponential backoff etc.)?
jayme-github@c25e016

@stevenroose
Copy link
Author

@jayme-github makes sense. I currently can't work on this as my computer recently got stolen. A separate PR maybe?

@jayme-github
Copy link

Let's see what the bfx people say. If they'r okay with it, I can send an additional PR (or you've merged my commit into your PR in the meantime :-))

@stevenroose
Copy link
Author

If you can file a PR in my fork from yours, I can. But I can't get into actual Git on this computer right now :p

@jvatianou-connamara
Copy link
Contributor

putting into review/qa for someone from bitfinex to ultimately merge.

thank you for the contribution.

@stevenroose
Copy link
Author

It seems to have an ACK from bitfinex for a long time :D

@d8x
Copy link

d8x commented Oct 10, 2023

any updates on that topic? Would be great to have that merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants