Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI pipeline by adding format validation for project links in lngal_data.json before publishing.
- Switched JSON validation commands from
pythontopython3 - Introduced a new workflow step to validate link objects (checking for required fields and URL formatting)
Comments suppressed due to low confidence (3)
.github/workflows/deploy.yml:50
- Indentation of this step is inconsistent with other steps and will cause the workflow YAML to fail. Align it under the same indentation level as the surrounding steps (e.g., 8 spaces).
- name: Validate project links
.github/workflows/deploy.yml:51
- [nitpick] The inline Python script is lengthy and embedded directly in the workflow, which can be hard to maintain and test. Consider extracting it into a separate script (e.g.,
scripts/validate_links.py) and calling that here.
run: |
.github/workflows/deploy.yml:52
- There are no dedicated tests for the new link validation logic. Adding unit tests or a sample JSON in a test suite would help ensure both valid and invalid link scenarios are covered.
echo "🔍 Validating project links format..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightning Network Gallery Update
Description
Brief description of what this PR changes:
Changes Made
added a validator for project links
New Projects Added:
N/A
Updated Projects:
Data Quality Checklist:
Testing
Additional Notes
For Maintainers: