Skip to content

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Aug 21, 2025

Description

Compilation (before this PR) of the library generates a lot of warnings on Elixir 1.17+:

     warning: using single-quoted strings to represent charlists is deprecated.
     Use ~c"" if you indeed want a charlist or use "" instead.
     You may run "mix format --migrate" to change all single-quoted
     strings to use the ~c sigil and fix this warning.
     │
 211 │     '}'
     │     ~
     │
     └─ lib/encode.ex:211:5

Motivation and Context

The goal is to see clearer in remaining warnings & test failures on Elixir 1.18+, as I'm using the library.

Types of changes

I ran mix format --migrate on Elixir 1.18, and kept only the ~c migration relevant bits.

@andreasknoepfle andreasknoepfle merged commit c70f8d3 into bitcrowd:main Aug 25, 2025
4 of 6 checks passed
@thbar thbar deleted the format/use-c-sigil branch August 25, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants