Skip to content

Conversation

@praveenperera
Copy link
Contributor

@praveenperera praveenperera commented Jan 23, 2026

Closes #459

Summary by CodeRabbit

Release Notes

  • Refactor
    • Enhanced layout system for recovery word displays across wallet creation and recovery screens
    • Improved grid alignment and column-based arrangement for consistent visual presentation
    • Optimized spacing in word display layouts across both Android and iOS platforms

✏️ Tip: You can customize this high-level summary in your review settings.

@greptile-apps
Copy link

greptile-apps bot commented Jan 23, 2026

Automatic reviews are disabled for this repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes restructure seed word displays across Android and iOS platforms from left-to-right (row-major) layout to top-down (column-major) layout. Grid implementations are replaced with explicit column-major index calculations and multi-column layouts to ensure consistent word ordering across all screens.

Changes

Cohort / File(s) Summary
Android seed word grid layouts
android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreen.kt, android/app/src/main/java/org/bitcoinppl/cove/secret_words/SecretWordsScreen.kt, android/app/src/main/java/org/bitcoinppl/cove/views/RecoveryWords.kt
Replace row-based grid layouts with column-major iteration; add divisibility check (word count ÷ 3); compute wordsPerColumn; calculate explicit indices per cell (col \* wordsPerColumn + row); iterate columns then rows to render items top-to-bottom. Remove LazyVerticalGrid and nested Row/Column helpers.
iOS seed word grid layouts
ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletCreateScreen.swift, ios/Cove/Flows/SelectedWalletFlow/SecretWordsScreen.swift
Replace vertical grid (LazyVGrid) with horizontal grid (LazyHGrid) and column-major layout; add numberOfColumns = 3; enforce divisibility via precondition; compute numberOfRows = wordCount / numberOfColumns; use GridItem(.flexible()) for row sizing. Adjust spacing and item width constraints.
iOS import field layout
ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletImportCard.swift
Introduce dynamic two-column layout with numberOfColumns = 2; replace fixed row height with GridItem(.flexible()); compute columnWidth dynamically from geometry; apply frame constraint to each AutocompleteField.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 Three columns tall, from top we read,
Words stack down where they should spread,
No more left-right chaos shown,
Vertical order, cleanly known! ✨

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenperera praveenperera deleted the pr/seed-word-order branch January 23, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change seed word order to be consistent

2 participants