Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 309 (2024-06-28) #1752

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

harding
Copy link
Collaborator

@harding harding commented Jun 26, 2024

Copy link

@stefanwouldgo stefanwouldgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last paragraph about the comparison to min cost flow probabilities is misleading IMHO (because the OP is): the min cost flow probabilities and the feasibility probabilities are over different and incompatible probability spaces, so comparing them doesn’t really make sense. I think it’s best to just scrap that paragraph.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far

Copy link

@renepickhardt renepickhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with @stefanwouldgo: While the probability that a payment is feasible (blue curve) is indeed not the same as the success probability of a single round of MPP attempts (green curve) I think the comparison of these two still makes some sense.

For example the likelihood that the payment is feasible was for all amounts larger than the likelihood for a single round of attempt to be successful (thus the MCF curve lies below the other one). For me this was meainly meant as a sanity check that the provided approach is not obviously stupid. Maybe I should have stated this a bit more clearly

I would not scratch that paragraph, because indeed the likelihood of feasibility gives a useful baseline (also for the usecases that David suggested on delving e.g. knowing if one can receive money)

@harding
Copy link
Collaborator Author

harding commented Jun 26, 2024

@stefanwouldgo

The last paragraph about the comparison to min cost flow probabilities is misleading IMHO (because the OP is): the min cost flow probabilities and the feasibility probabilities are over different and incompatible probability spaces, so comparing them doesn’t really make sense. I think it’s best to just scrap that paragraph.

@renepickhardt

I disagree with @stefanwouldgo: While the probability that a payment is feasible (blue curve) is indeed not the same as the success probability of a single round of MPP attempts (green curve) I think the comparison of these two still makes some sense.

I'll be deleting the clause "Pickhardt [...] compares the likelihood of feasibility to the likelihood of a minimum cost flow solver making a successful payment" but I'm keeping (with some revision) "It also provides a useful basis for comparison." That removes mention of the specific comparison that seems debatable while still mentioning that it can be useful for making some sort of comparisons, which seems unquestionably true to me. It also addresses Rene's line comments.

   The likelihood of feasibility makes it clear that many LN payments
   that naively seem possible will not succeed in practice.  It also
-  provides a useful basis for comparison: Pickhardt provides a graph for
-  a simulated network that compares the likelihood of feasibility to the
-  likelihood of a minimum cost flow solver making a successful payment,
-  showing the solver succeeding most of the time a payment is possible.
-  In a [reply][pickhardt feasible2], he also describes how the
+  provides a useful basis for making comparisons.
+  In a [reply][pickhardt feasible2], Pickhardt describes how the
   likelihood metric could be used by wallets and business software to
   automatically make some intelligent decisions on behalf of its users.

@stefanwouldgo
Copy link

Thank you. This seems like a good solution to me. I have added a counterexample to the original discussion (https://delvingbitcoin.org/t/estimating-likelihood-for-lightning-payments-to-be-in-feasible/973/5).

@renepickhardt
Copy link

Thank you. This seems like a good solution to me. I have added a counterexample to the original discussion (https://delvingbitcoin.org/t/estimating-likelihood-for-lightning-payments-to-be-in-feasible/973/5).

As laid out in my reply I don't think you provided a counter example:
https://delvingbitcoin.org/t/estimating-likelihood-for-lightning-payments-to-be-in-feasible/973/6


- [LND v0.18.1-beta][] is a minor release with a fix for "an [issue][lnd
#8862] that arises when handling an error after attempting to
broadcasting transactions if a btcd backend with an older version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is within a quote so may not be fixable?

Suggested change
broadcasting transactions if a btcd backend with an older version
broadcast transactions if a btcd backend with an older version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the edit. I think it's fine. I don't like editing if it's the quoted author's style choice or if there's any risk of changing the meaning, but small edits to fix clear typos are ok.

@Gustavojfe
Copy link
Contributor

just pushed all the merge summaries for this week's newsletter, left a comment on the 2nd one, Bitcoin Core #28984.

Copy link
Collaborator Author

@harding harding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few FYIs for the future for @Gustavojfe

all non-connecting headers as potential announcements.

- [Bitcoin Core #28984][] adds support for a limited version of [package][topic
package relay] [replace-by-fee][topic rbf] with clusters of size two including
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gustavojfe Making a small edit here: "package replace-by-fee" is the correct term and linking to our topic pages on those separate topics is also good, but we have a previously unwritten rule about avoiding two links in sequence because they look like one link. I'll add that rule to the style guide now.

[Topologically Restricted Until Confirmation (TRUC)][topic v3 transaction
relay] transactions (aka v3 transactions). These clusters can only replace an
existing cluster of the same size or smaller. See [Newsletter #296][news296
packagerbf] for related context. <!-- there’s no specific mention in the PR that TRUC transactions are supported for package RBF but from my understanding, and from what was said in Newsletter #296, it is the case?-->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like it doesn't enforce the TRUC size restrictions, but it is limited to 1-parent-1-child. Your description looks correct to me, so I'm going to delete the comment. Thanks for checking!

reference to this command.

- [LDK #3127][] implements non-strict forwarding to improve payment reliability,
allowing [Hash Time Locked Contract (HTLCs)][topic htlc] to be forwarded to a
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gustavojfe FYI: we don't need to expand abbreviations for which we have a topic page; it's ok to just link to them instead (e.g. [HTLC][topic htlc]). TRUC, used above, is still a bit new, so I'm leaving that in, but I think we can stop expanding that in future newsletters.

@harding
Copy link
Collaborator Author

harding commented Jun 28, 2024

Made edits for all feedback, thanks @LarryRuane @stefanwouldgo @renepickhardt @bitschmidty @azuchi ! Added lede, releases/RCs, and topic entries. Reviewed contributions by @bitschmidty and @Gustavojfe (thanks so much!). Thanks everyone!

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK lede, topics, and style guide updates

@bitschmidty bitschmidty force-pushed the 2024-06-28-newsletter branch from 9c4ec2b to 2cee0bb Compare June 28, 2024 11:32
@bitschmidty bitschmidty merged commit ea0b0a8 into bitcoinops:master Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants