Removed unnecessary check for tapInternalKey for signature validations of taproot inputs #2270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTaprootHashesForSigis an overly reused function for both signing as well as signature validation.To better make each path clearer, we created two wrappers on top to clearly state its intent,
getTaprootHashesForSigValidationandgetTaprootHashesForSigning. Note thatgetAllTaprootHashesForSigis just renamed togetAllTaprootHashesForSigValidation, since there isn't a corresponding usage for signing.This separation allows for us to clearly see that for sig validation, we only need to see the existence of tapKeySig to know that this is a key spend path. This is especially important for nonstandard key spend path patterns such as MuSig2 or other offchain multisig signing protocols.