secp-api/secp-bouncy: backport to Java 8 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgilligan
force-pushed
the
msgilligan/api-bouncy-java-8
branch
from
5336a79 to
8d68d1d
Compare
|
If this is approved/merged, I plan to backport it to the 0.0.2 branch before releasing it. @schildbach This should allow us to start experimental refactoring of |
msgilligan
force-pushed
the
msgilligan/api-bouncy-java-8
branch
from
8d68d1d to
52b3e2c
Compare
|
@craigraw This shouldn't affect you, but I thought you might be interested and you also have experience with modules so maybe you might have an idea for improvement. |
craigraw
approved these changes
Feb 27, 2025
schildbach
approved these changes
Feb 27, 2025
secp-api/src/main/java/org/bitcoinj/secp/api/Secp256k1Provider.java
Outdated
Show resolved
Hide resolved
* IDEs will see secp-api, secp-bouncy modules as Java 9 * apiModuleJavaCompatibility property is used with `org.beryx.jar` Gradle plugin to create Java 8 JARs with module-info on official builds * Remove usages of Java 9 API in secp-api and secp-bouncy Developers of secp-jdk using IDEs will need to be aware that the actual requirements are Java 8 API. But mistakes will be caught by CI.
msgilligan
force-pushed
the
msgilligan/api-bouncy-java-8
branch
from
52b3e2c to
de600d7
Compare
Technically they aren't multi-release jars. They're just Java 8 JARs with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR means that released jars for the API and the Bouncy Castle implementation will be Java 8-compatible, but will still have
module-inforecords in them. Thesecp-ffmmodule will remain at JDK 23+.Developers of secp-jdk using IDEs will need to be aware that the actual requirements are Java 8 API. But mistakes will be caught by CI.