Skip to content

Use Esplora's get_block_hash() method #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Oct 20, 2022

Description

This PR makes use of the recently added get_block_hash() API method of the Esplora client.

Previously, we retrieved the entire header to extract the BlockHash. Funnily enough, the header was internally retrieved through a combination of getting hash by height and then getting the header by hash.

Notes to the reviewers

This is currently blocked on the next release of rust-esplora-client.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rajarshimaitra
Copy link
Contributor

Seems like this needs a new release of esplora-client?

@tnull
Copy link
Contributor Author

tnull commented Oct 20, 2022

This is currently blocked on the next release of rust-esplora-client.

Correct, as noted in the description. Feel free to add a corresponding tag.

@notmandatory
Copy link
Member

The new esplora-client 0.2 was released today and will get updated in the upcoming bdk 0.24.0 milestone via #770. Since this PR doesn't look like an urgent change I added it to the 0.25.0 bdk milestone.

@tnull tnull force-pushed the 2022-10-use-get-block-hash branch from e9024cb to c0e9ca3 Compare October 25, 2022 08:02
@tnull
Copy link
Contributor Author

tnull commented Oct 25, 2022

The new esplora-client 0.2 was released today and will get updated in the upcoming bdk 0.24.0 milestone via #770. Since this PR doesn't look like an urgent change I added it to the 0.25.0 bdk milestone.

Fine with both, really no urgency from my side. That said, I'll rebase as soon as #770 lands.

@afilini
Copy link
Member

afilini commented Oct 26, 2022

Sorry I missed this PR and did the same change in #770 (your deprecation notice was very helpful!).

I'm going to close this one since it won't be needed anymore, sorry for not noticing it before.

@afilini afilini closed this Oct 26, 2022
@notmandatory notmandatory removed this from the Release 0.25.0 Feature Freeze milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants