Skip to content

[Demo] Add BIP322 implementation #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aagbotemi
Copy link

Description

This PR implements the BIP322 standard for generic signed message in Bitcoin

Features

  • Core message signing and verification
  • Support for Legacy, Simple and Full
  • Test suites to cover edge cases
  • Comments to explain functionality

Notes to the reviewers

This PR is intended as demonstration of BIP322 and it is open for feedback

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@aagbotemi aagbotemi marked this pull request as ready for review March 17, 2025 01:34
@aagbotemi aagbotemi marked this pull request as draft March 17, 2025 01:34
@notmandatory notmandatory added the new feature New feature or request label Mar 19, 2025
@notmandatory notmandatory moved this to In Progress in BDK Wallet Mar 19, 2025
@notmandatory
Copy link
Member

fixes bitcoindevkit/bdk_wallet#150

@aagbotemi aagbotemi marked this pull request as ready for review March 19, 2025 11:48
@notmandatory
Copy link
Member

@aagbotemi please rebase this PR to fix the CI issues.

Also this is a pretty big PR that will need careful review due to the use of private keys. Please be patient as it will take some time to get proper reviews done. Thanks!

@aagbotemi aagbotemi force-pushed the feature/bip322-support branch from f2405e8 to eded159 Compare March 24, 2025 10:04
@aagbotemi
Copy link
Author

Hi @notmandatory. I have rebased this PR.

@luisschwab
Copy link
Member

Hey @aagbotemi, this PR needs to be closed and moved to the new bdk_wallet repo. Here's how:

  1. From your Github account, fork https://github.com/bitcoindevkit/bdk_wallet
  2. From your local system bdk repo folder, push your PR changes to your bdk_wallet fork on Github:
    git checkout <PR branch path>
    git push [email protected]:<username>/bdk_wallet.git
    
  3. Clone to your forked bdk_wallet repo to your local system and switch to your PR branch:
    git clone [email protected]:<username>/bdk_wallet.git
    cd bdk_wallet
    git fetch origin <PR branch path>
    git checkout -b <PR branch path> FETCH_HEAD
    git rebase master
    
  4. Resolve rebase conflicts (if any)
  5. Force push your PR branch: git push origin -f
  6. Create new PR in bitcoindevkit/bdk_wallet repo from your fork branch
  7. Copy/paste title and description from your original bdk PR and add a link back to it in your new PR.
  8. Close original PR with comment that includes link to new PR.

@notmandatory notmandatory moved this to Discussion in BDK Chain Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Discussion
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants