-
Notifications
You must be signed in to change notification settings - Fork 390
[Demo] Add BIP322 implementation #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aagbotemi
wants to merge
2
commits into
bitcoindevkit:master
Choose a base branch
from
aagbotemi:feature/bip322-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aagbotemi please rebase this PR to fix the CI issues. Also this is a pretty big PR that will need careful review due to the use of private keys. Please be patient as it will take some time to get proper reviews done. Thanks! |
f2405e8
to
eded159
Compare
Hi @notmandatory. I have rebased this PR. |
Hey @aagbotemi, this PR needs to be closed and moved to the new bdk_wallet repo. Here's how:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the BIP322 standard for generic signed message in Bitcoin
Features
Notes to the reviewers
This PR is intended as demonstration of BIP322 and it is open for feedback
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: