-
Notifications
You must be signed in to change notification settings - Fork 390
Add zizmor github actions security analysis workflow #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
42bcf95
to
95e53d0
Compare
Rebased on updated and merged #1778 ready to review and merge, zizmor finds no issues now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good and it's a pretty good addition.
I left a minor comment and another one regarding my concerning on relying on another action for what it seems just python package management.
.github/workflows/zizmor.yml
Outdated
contents: read | ||
actions: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a public repo, this could be removed ?
.github/workflows/zizmor.yml
Outdated
- name: Install the latest version of uv | ||
uses: astral-sh/setup-uv@v5 | ||
|
||
- name: Run zizmor 🌈 | ||
run: uvx zizmor --format sarif . > results.sarif | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having a zizmor
job, however, I'm wondering if there's another simpler/safer way to run it, instead of bringing this new action (setup-uv) AFAICT just for the python package manager 🤔
Took this out of the |
Moved to |
Reopening since we need to audit CI actions for this repo too. |
Pushed changes to match bitcoindevkit/bdk_wallet#8. |
2ed16e8
to
0e048a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 2a2f04c
AFAICT the conflicts are only happening as [email protected]
was bumped recently.
Description
Added workflow to run zizmor github actions security analysis.
See: https://woodruffw.github.io/zizmor/usage/#use-in-github-actions
Notes to the reviewers
I built this PR on top of #1778.
I pinned zizmor to version 1.6.0, and rust-cache to 2.7.8 (hash 9d47c6ad4b02e050fd481d890b2ea34778fd09d6).
Changelog notice
ci: add zizmor github actions security analysis workflow and fix possible vulnerabilities
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing