Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kyoto to latest version #93

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

rustaceanrob
Copy link
Collaborator

@rustaceanrob rustaceanrob commented Jan 14, 2025

kyoto now splits the messages a node emits into 3 categories: Log, Warning, Event. Each of these can be polled individually for new messages, and the entire receiver of Event can be wrapped to construct a wallet update. Since these receivers of Log and Warning can just be passed on to the developer, the need for logging wrappers or callbacks is removed.

@rustaceanrob rustaceanrob force-pushed the update-1-9 branch 2 times, most recently from 0c27b92 to 316c2eb Compare January 15, 2025 20:41
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK

src/lib.rs Show resolved Hide resolved
examples/example.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@rustaceanrob rustaceanrob marked this pull request as ready for review January 20, 2025 19:47
@rustaceanrob rustaceanrob changed the title WIP upgrade kyoto to latest version Upgrade kyoto to latest version Jan 20, 2025
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eed849e

@rustaceanrob rustaceanrob merged commit dff01cd into bitcoindevkit:master Jan 20, 2025
2 checks passed
@rustaceanrob rustaceanrob deleted the update-1-9 branch January 20, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants