Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add simple electrum client #535

Merged
merged 8 commits into from
May 16, 2024
Merged

feat: add simple electrum client #535

merged 8 commits into from
May 16, 2024

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented May 14, 2024 •
edited
Loading

This PR brings in the new Electrum client. I have tested locally by replacing the Esplora clients with Electrum clients, and all tests pass.

Notes to the reviewers

Changelog notice

Added
  - Add Electrum client [#535]

[#535]: https://github.com/bitcoindevkit/bdk-ffi/pull/535

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit force-pushed the feature/electrum-client branch from 551c5bf to c2fd789 Compare May 15, 2024 16:36
@thunderbiscuit thunderbiscuit force-pushed the feature/electrum-client branch from d99ad17 to 1059578 Compare May 16, 2024 13:31
@thunderbiscuit thunderbiscuit mentioned this pull request May 16, 2024
Merged
3 tasks
@thunderbiscuit thunderbiscuit force-pushed the feature/electrum-client branch from 1059578 to ca8a3d0 Compare May 16, 2024 14:41
@thunderbiscuit thunderbiscuit requested a review from reez May 16, 2024 14:43
reez
reez approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca8a3d0

Really clean and consistent and crisp 🚀

@thunderbiscuit thunderbiscuit merged commit ca8a3d0 into bitcoindevkit:master May 16, 2024
25 checks passed
@thunderbiscuit thunderbiscuit deleted the feature/electrum-client branch May 16, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reez reez reez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thunderbiscuit @reez