Skip to content

BIP328: Use Base58Check in ExtendedKey.deserialize and validate length #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

BIP328: Use Base58Check in ExtendedKey.deserialize and validate length #1955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd9f569
Use Base58Check in ExtendedKey.deserialize and validate length
sashass1315 Sep 5, 2025
fc10bd4
Update bip-0328/_xpub.py
sashass1315 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bip-0328/_xpub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ def deserialize(cls, xpub: str) -> 'ExtendedKey':

:param xpub: The Base58 check encoded xpub
"""
data = base58.decode(xpub)[:-4] # Decoded xpub without checksum
data = base58.decode_check(xpub)
if len(data) != 78: # BIP32 Serialization Format defines a 78-byte structure.
raise ValueError("Invalid extended key length")
return cls.from_bytes(data)

@classmethod
Expand Down