ecdsa adaptor sigs [WIP] #861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasnick
reviewed
Dec 23, 2020
Contributor
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
This is really cool - thank you for taking it over.
The current consensus is that this library should focus on the demands of Bitcoin Core. Modules outside of that focus can go into the libsecp-zkp fork. I initially wrote this code on top of libsecp, because libsecp-zkp was not up-to-date with the most recent libsecp. But that's not the case anymore and we have mechanisms in place now to bring libsecp-zkp in sync. Therefore, I'd recommend to rebase on top of libsecp-zkp (which should be very straightforward) and open a PR there.
Author
|
@jonasnick Thanks for the heads-up! I will re-open the PR in libsecp-zkp. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.