Enhanced Traffic Graph Widget with Multi-timeframe Support and Data Persistence #866
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
rebroad
force-pushed
the
trafficgraphwidget-rebased
branch
from
530adae to
31b1ffc
Compare
rebroad
changed the title
src/qt/trafficgraphwidget.cpp
Outdated
| // Restore the saved total bytes counts to the node if they exist | ||
| if (m_total_bytes_recv > 0 || m_total_bytes_sent > 0) { | ||
| model->node().setTotalBytesRecv(m_total_bytes_recv); | ||
| model->node().setTotalBytesSent(m_total_bytes_sent); | ||
| } |
There was a problem hiding this comment.
The GUI should not be changing low-level internals.
If for some reason the clientModel is changed, its data should be taken as authoritative, even if it contradicts the history so far (if that's an issue, wipe the history).
Alternatively, maybe the history should be stored with the node, and loaded into the GUI (or RPC, in another hypothetical PR).
There was a problem hiding this comment.
The idea is that the data is not persistent - but yes, I see your point - it should probably not be something that only happens when the GUI is running, and should perhaps also happen in bitcoind also.
| @@ -694,16 +703,6 @@ | |||
| </property> | |||
| </widget> | |||
| </item> | |||
| <item> | |||
| <widget class="QPushButton" name="btnClearTrafficGraph"> | |||
There was a problem hiding this comment.
If we're deleting this, maybe there should be a way for the user to insert a reference line?
For now, I'd move removal of anything to a separate PR.
There was a problem hiding this comment.
The user can effectively remove the data by deleting the .dat file - is there any basis for being able to do this while the client is running?
| @@ -578,7 +576,7 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformSty | |||
| // based timer interface | |||
| m_node.rpcSetTimerInterfaceIfUnset(rpcTimerInterface); | |||
|
|
|||
| setTrafficGraphRange(INITIAL_TRAFFIC_GRAPH_MINS); | |||
There was a problem hiding this comment.
Why are we losing this default constant?
There was a problem hiding this comment.
because it isn't needed - on startup it "defaults" to the first non-full range
I vaguely remember people complaining that I was raising several PRs that could be combined when I first raised the PRs years ago.... I guess one cannot please everyone all of the time. |
Add a new GUI utility function to format bytes per second values with appropriate units (B/s, kB/s, MB/s, GB/s) and precision, ensuring consistent and readable display of network traffic rates in the traffic graph widget.
Add functions to set total bytes sent/received counts to enable restoring traffic statistics between application sessions. This allows for continuous traffic monitoring even after application restarts, improving the usefulness of the traffic graph widget.
Adds a new utility function FormatISO8601Time that formats a Unix timestamp into an ISO 8601 time string (HH:MM:SSZ). This complements the existing FormatISO8601DateTime and FormatISO8601Date functions, providing a way to format just the time component of a timestamp. The function uses C++20 chrono features to handle time calculations and formatting, maintaining consistency with the existing ISO 8601 formatting functions.
…persistence
This commit significantly improves the network traffic graph widget with:
1. Multiple timeframe support - View traffic data across different time
periods (5 minutes to 28 days) using an enhanced slider interface
2. Traffic data persistence - Save and restore traffic information
between sessions, preserving historical traffic patterns
3. Interactive visualization features:
- Logarithmic scale toggle (mouse click) for better visualization of
varying traffic volumes
- Interactive tooltips showing detailed traffic information at specific points
- Yellow highlight indicators for selected data points
4. Smooth transitions between different time ranges with animated scaling
These improvements allow users to better monitor and analyze network
traffic patterns over time, which is especially useful for debugging
connectivity issues or understanding network behavior under different
conditions.
The implementation includes proper thread-safety considerations and
handles edge cases like time jumps or missing data appropriately.
rebroad
force-pushed
the
trafficgraphwidget-rebased
branch
from
31b1ffc to
ab7bbd0
Compare
laanwj
changed the title
This PR improves the network traffic graph widget in the Debug window to provide:
Motivation
The existing network traffic graph has limited utility with its fixed time range and lack of historical data preservation. This enhancement allows users to:
These improvements are valuable for:
Implementation
The implementation preserves all existing functionality while adding new features:
Supporting changes:
Testing
Tested on Linux with various network conditions. The new functionality can be exercised by:
Documentation
The changes are mostly self-documenting through the UI and are constrained to the Qt interface without affecting core functionality.
Compatibility
This PR maintains compatibility with existing functionality. The data persistence file uses proper serialization versioning to allow for future format changes if needed.