Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc docs: remove docs for EOL versions #914

Closed
wants to merge 1 commit into from

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 14, 2022

Removes the RPC documentation for 0.16.0, 0.16.1, 0.16.2, 0.16.3, 0.17.0, 0.18.0, 0.19.0, 0.20.0.
Keeps 0.21 for now as it's only just gone EOL (happy to remove if preferred).
24.0 should be added shortly.

@fanquake fanquake marked this pull request as draft November 14, 2022 12:26
Keep 0.21 for now as it's only just gone EOL.
24.0 should be added shortly.
@fanquake fanquake marked this pull request as ready for review November 14, 2022 13:09
@harding
Copy link
Contributor

harding commented Nov 14, 2022

What's the motivation for removing the older documentation, beyond them documenting EOL versions? Removing those pages will break any links to them, and I know I've occasionally used the old documentation to get information about old versions---maybe others have also?

Copy link

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe here instead of removing the doc that it is EOL it is better to add an alert in the index that it is time to upgrade?

@glozow
Copy link
Member

glozow commented Nov 14, 2022

Would it be difficult to keep these? Agree cleanup and reducing the amount of things to maintain is good, but I must admit that there are a few links to RPC docs in the review club website, e.g. here.

@fanquake
Copy link
Member Author

Ok. Will leave these as-is for now. Maybe we should add some/all of the missing versions?

@fanquake fanquake closed this Nov 14, 2022
@fanquake fanquake deleted the remove_rpc_doc_eol branch November 14, 2022 15:32
@0xB10C
Copy link
Contributor

0xB10C commented Nov 14, 2022

Issue about potentially adding docs for older versions #921 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants