Skip to content

Conversation

@0xf0xx0
Copy link
Contributor

@0xf0xx0 0xf0xx0 commented Jun 25, 2025

old:
image

new:
image

doesnt need anything done for the smaller scales

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jun 25, 2025

an alternative could be to swap the logo and the hamburger, this might fit better with the expanded ui
image
image

@duckaxe
Copy link
Collaborator

duckaxe commented Jun 25, 2025

My 2 cent:

  1. Please wait for Hostname & WiFi RSSI at header/menu #1056
  2. I wouldn't touch the logo and menu button again. With Hostname & WiFi RSSI at header/menu #1056 they are perfectly tuned. Both of your suggestions are not good, they cause disorder in the design. Things need to be aligned.
Screenshot 2025-06-25 at 18 59 00

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jun 25, 2025

with your pr the hamburger is still floating by itself. to me it feels off, especially once the sidebar has been folded. i'll set this as a draft until yours is merged uwu

@0xf0xx0 0xf0xx0 marked this pull request as draft June 25, 2025 17:09
@duckaxe
Copy link
Collaborator

duckaxe commented Jun 25, 2025

with your pr the hamburger is still floating by itself.

Thats right. The menu button is not part of the logo, no matter where it is located - left or right next to the logo. Your suggestions imply an association between the two elements due to their proximity. That's not how it should be, though. They have nothing to do with each other. That's why it's good that they are far apart. This is not a bug, it's a feature.

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jun 25, 2025

while i see that, i think its not an issue? most sites place their logo on the right side of the hamburger, like amazon. and again, it being so far off looks weird when the sidebar is folded. maybe the logo should be place to the right edge and the hamburger on the left, like on the mobile ui?

@mutatrum mutatrum added the design Design Enhancements label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Design Enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants