Skip to content

Conversation

@cleWu03
Copy link
Contributor

@cleWu03 cleWu03 commented Mar 14, 2025

Summary

Calculate the offset for the go to ball position depending on the relative position to the ball

Proposed changes

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

# Offset so we kick the ball with one foot instead of the center between the feet
self.side_offset = parameters.get("side_offset", 0.08)
self.side_offset = parameters.get("side_offset", 0.00)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move foot selection here

@jaagut jaagut moved this from 🆕 New to 👀 In review in Software Mar 15, 2025
@jaagut jaagut requested a review from Flova May 4, 2025 12:54
@jaagut
Copy link
Member

jaagut commented May 4, 2025

@cleWu03 I've just re-requested a review from @Flova, so he gets notified again.

@Flova
Copy link
Member

Flova commented May 4, 2025

We did some testing during the Go, which still had some issues iirc.. Maybe @cleWu03 remembers more or we can test it in sim.

@jaagut
Copy link
Member

jaagut commented Nov 22, 2025

@cleWu03 please provide some info on the current status.

@Flova
Copy link
Member

Flova commented Nov 23, 2025

I think there are some issues with it not being stable on the real robot

@cleWu03
Copy link
Contributor Author

cleWu03 commented Nov 23, 2025

this was only approach for a quick fix during the GO, i will close it

@cleWu03 cleWu03 closed this Nov 23, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Software Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants