-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARCED new organization #33
Draft
ChocolateCharlie
wants to merge
199
commits into
birtwistlelab:master
Choose a base branch
from
ChocolateCharlie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recompile SPARCED_legacy with the original Jupyter Notebook under the name SPARCED_legacy (ensures compatibility with version 2.0.0) Run a default simulation of SPARCED_legacy on the original Jupyter Notebook with perturbations as specified in the default.txt file
Run SPARCED_legacy model using the 2.0.0 pipeline under the same conditions as with the 1.3.0 control Results showed no difference at all between both, but the 1.3.0 version doesn't save time by default, which is useful for plotting.
Recompile SPARCED_standard with the original legacy SPARCED input data files (v1.3.0) using the 2.0.0 pipeline Run a default simulation of SPARCED_standard using the 2.0.0 pipeline with perturbations as specified in the default.txt file Those control results are strictly identical to those for SPARCED_legacy
This pipeline was tested on the SPARCED_standard model for a) no incubation specified at all b) an incubation defined to 0 hours and c) an incubation set to 24 hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the SPARCED's new organization.
Although some further work could be done (add scripts for incubation, improve file handling, tidy up run SPARCED scripts etc. - there could always be more work), this version recapitulates in a new organization the current SPARCED's model on the main branch.
Both Arnab and Jonah got it working on their own machines, so it's reproducible.
After merging my branch, we could launch the Read The Docs to get beautiful documentation online, under the form of a website 😄