Sitekwb/issue6 - #298
Open
sitekwb wants to merge 2 commits into
Open
Conversation
sitekwb
commented
Feb 12, 2026
sitekwb
commented
Contributor
- Added validation to ensure that the on_cols parameter is not provided for naive operations (coverage and count_overlaps).
- Updated error handling to return informative messages when on_cols is used incorrectly.
- Enhanced tests to verify that appropriate errors are raised when on_cols is used with naive_query=True, while allowing it in non-naive operations.
Collaborator
|
@sitekwb pls rebase and resolve conflicts |
- Updated range operation functions to accept and validate on_cols parameter, ensuring it is a list of strings or None. - Modified query generation to include additional WHERE conditions based on on_cols. - Updated related structures and functions to accommodate on_cols, improving flexibility in overlap queries. Bump polars_bio version to 0.22.0 in Cargo.lock.
- Added validation to ensure that the on_cols parameter is not provided for naive operations (coverage and count_overlaps). - Updated error handling to return informative messages when on_cols is used incorrectly. - Enhanced tests to verify that appropriate errors are raised when on_cols is used with naive_query=True, while allowing it in non-naive operations.
sitekwb
force-pushed
the
sitekwb/issue6
branch
from
February 22, 2026 17:25
39110e0 to
7491171
Compare
Contributor
Author
|
@mwiewior I did it, please check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.