feat: make GITHUB_TOKEN optional for fetch #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daler
approved these changes
Nov 30, 2023
daler
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [2.11.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.10.0...v2.11.0) (2023-11-30) ### Features * make GITHUB_TOKEN optional for fetch ([#942](https://www.github.com/bioconda/bioconda-utils/issues/942)) ([c0eab1d](https://www.github.com/bioconda/bioconda-utils/commit/c0eab1d7224d6b13ebe399e7933460249e4e9a58)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the GITHUB_TOKEN environment variable exists for getting the PR during artifact fetching. Since it's a read-only request, it works without a token. The risk is that GitHub API has a 60 request/hr limit for unauthenticated users associated with the originating IP address. https://docs.github.com/en/rest/overview/rate-limits-for-the-rest-api
We talked about adding a flag to specify not using the token, but I thought it would be cleaner to just log a warning and proceed. (Also open to adjusting the retry for the tokenless option, but usually a rate limit would be 429 return code and this retry policy is only for 500, 502, 504.)