Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hashtags to notes and displaying relevant lists #43

Closed
wants to merge 20 commits into from
Closed

Adding hashtags to notes and displaying relevant lists #43

wants to merge 20 commits into from

Conversation

tannerdolby
Copy link

@tannerdolby tannerdolby commented Dec 28, 2020

Hey! @binyamin

I saw your last message in #33 and decided to make a new branch and a fresh PR for you to review. I hope your doing well and I'll plan on chatting with you soon.

This PR does successfully create and display hashtag permalinks with lists of relevant note lists, but the problem of dynamically displaying and grabbing the hashtags without the user supplying the hashtags to pagination data still needs to be sorted out.

@binyamin binyamin self-requested a review December 28, 2020 16:35
@binyamin binyamin linked an issue Dec 28, 2020 that may be closed by this pull request
@binyamin
Copy link
Owner

Can you remind me how we're differentiation wikilinks and tags?

@tannerdolby
Copy link
Author

tannerdolby commented Dec 28, 2020

Yeah, in terms of style, the wikilinks are:mediawiki-style, internal - [[ bar.md | example b ]]

Where the hashtags are hashtag-style, internal - #tag - [#food](/notes/food/)

Also, in the Eleventy config file, we're using two separate .use() statements to recognize wikilinks and tags.

Some notes have the same filename as tags so thats why /tags/tag is currently being used in pagination permalinks to side step this

Other than that, the wikilinks provide a link to /notes/art where the hashtags are /notes/tags/art until the quote above is handled. So, there isn't a "huge" difference between the wikilink and tag functionality.

@binyamin
Copy link
Owner

@tannerdolby After careful procrastination — and laziness — I think that I'm going to wait for a dynamic solution. Thank you again for the PR.

@binyamin binyamin closed this Jan 26, 2021
@tannerdolby
Copy link
Author

@binyamin Your welcome. Best of luck. Cya around

@tannerdolby tannerdolby deleted the create-note-tag-lists branch January 26, 2021 22:39
@binyamin binyamin removed a link to an issue Jan 26, 2021
@binyamin binyamin removed their request for review January 26, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants