Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the full length routelines and stops[WIP] #412

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arindam1993
Copy link
Contributor

Getting there!

image

@abhumbla
Copy link
Contributor

abhumbla commented Jan 7, 2025

which stops outside the ridden segment get rendered?

@arindam1993
Copy link
Contributor Author

which stops outside the ridden segment get rendered?

All of them, but got some bugs happening at low zoom levels becoz tiles too big

@arindam1993
Copy link
Contributor Author

arindam1993 commented Jan 7, 2025

Tiles too big bcoz I added all the trip-is(as a comma-separated-string) of a stop to its geojson point feature
image

Here we have a 8.9K single point feature as a result 🙃

gotta add direction ids instead of trip-ids

@abhumbla
Copy link
Contributor

abhumbla commented Jan 7, 2025

All of them, but got some bugs happening at low zoom levels becoz tiles too big

imo we should only show the stops along the route, otherwise that might be too much?

@arindam1993
Copy link
Contributor Author

All of them, but got some bugs happening at low zoom levels becoz tiles too big

imo we should only show the stops along the route, otherwise that might be too much?

Try it out on staging! doesnt look overcrowded imo!

@graue
Copy link
Contributor

graue commented Jan 7, 2025

This is looking good. I agree with only showing the stops for the portion you're riding. Distracting to see them outside that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants