Repository navigation
Only require a key for modes that call the API - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdpromises "81 tests, all offline — no key needed". Via./start.sh testthat was false: the key check ran before mode dispatch, so every mode demanded a Groq key.Two modes it hurt most:
test— the entire suite is offline and usesFakeProvider. A contributor wanting to run tests was forced to sign up for an API key first.check— diagnosing a missing key is its whole purpose. It refused to start when the key was missing, which is exactly the situation it exists to explain.The key check now runs after mode dispatch and applies only to
run,demoandask.CI now runs the launcher
Three launcher bugs shipped in a row — Python not found on Windows, a two-word candidate that could not be invoked, and dependency installation silently skipped — because CI installed dependencies itself with
pip install -eand never touchedstart.sh. Every one was found by hand, by cloning the public repo into a clean directory.A second job now runs
./start.sh teston a clean checkout with no venv, no.envand no key, which is exactly the path all three bugs lived on. It also asserts that a keyless mode does not leave a stray.envbehind.