Skip to content

Make timeseries optional #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 9, 2025
Merged

Make timeseries optional #1575

merged 8 commits into from
Oct 9, 2025

Conversation

zitoa
Copy link
Contributor

@zitoa zitoa commented Oct 5, 2025 •
edited
Loading

Make timeseries optional. Needs bigomics/playbase#321

@zitoa zitoa requested a review from ESCRI11 October 5, 2025 13:46
@zitoa zitoa self-assigned this Oct 5, 2025
@zitoa zitoa added the enhancement New feature or request label Oct 5, 2025
@zitoa
Copy link
Contributor Author

zitoa commented Oct 5, 2025

Wait before review @ESCRI11 .
it needs some other fix.

@zitoa
Copy link
Contributor Author

zitoa commented Oct 5, 2025 •
edited
Loading

Ok should be ready for review now. @ESCRI11
Rationale: timeseries is complex. Only trigger if "time" is in colnames(samples) and if user selects "timeseries" and if any valid contrasts (not degenerated) are detected.

ESCRI11
ESCRI11 requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@ESCRI11 ESCRI11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On example data, which contains "time" column on samples I do not get the time series selector

@ESCRI11 ESCRI11 self-requested a review October 8, 2025 08:58
@ESCRI11
Copy link
Contributor

ESCRI11 commented Oct 9, 2025

  • Removed some vertical space
  • Added brackets [ ] on the variable name so it stands out
  • Changed "will be tested for the following valid variables" to "will be tested for the following valid contrasts"
  • Added a show more/show less if there are more than 3 valid contrasts

@ESCRI11 ESCRI11 linked an issue Oct 9, 2025 that may be closed by this pull request
request: explicit time variable for time series #1544
Closed
@ESCRI11 ESCRI11 merged commit 8124116 into devel Oct 9, 2025
@ESCRI11 ESCRI11 deleted the make-timeseries-optional branch October 9, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ESCRI11 ESCRI11 ESCRI11 approved these changes

Assignees

@zitoa zitoa

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

request: explicit time variable for time series

2 participants

@zitoa @ESCRI11