Skip to content

Explore DRYing out the Prometheus code. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alowde wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Explore DRYing out the Prometheus code. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33012d
refactor prometheus to DRY
alowde Nov 13, 2025
7b0dfa2
Finish refactor
alowde Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,6 @@ var (
log = logrus.New()
)

// var (
// cfgListen = ":8080"
// cfgCfAPIKey = ""
// cfgCfAPIEmail = ""
// cfgCfAPIToken = ""
// cfgMetricsPath = "/metrics"
// cfgZones = ""
// cfgExcludeZones = ""
// cfgScrapeDelay = 300
// cfgFreeTier = false
// cfgMetricsDenylist = ""
// )

func getTargetZones() []string {
var zoneIDs []string

Expand Down Expand Up @@ -103,7 +90,7 @@ func filterExcludedZones(all []cfzones.Zone, exclude []string) []cfzones.Zone {
return filtered
}

func fetchMetrics(deniedMetricsSet MetricsSet) {
func fetchMetrics(deniedMetricsSet []string) {
var wg sync.WaitGroup
accounts := fetchAccounts()

Expand Down Expand Up @@ -163,19 +150,15 @@ func runExporter() {
if len(viper.GetString("metrics_denylist")) > 0 {
metricsDenylist = strings.Split(viper.GetString("metrics_denylist"), ",")
}
metricsSet, err := buildFilteredMetricsSet(metricsDenylist)
if err != nil {
log.Fatalf("Error building metrics set: %v", err)
}
log.Debugf("Metrics set: %v", metricsSet)
mustRegisterMetrics(metricsSet)

mustRegisterMetrics(metricsDenylist)

scrapeInterval := time.Duration(viper.GetInt("scrape_interval")) * time.Second
log.Info("Scrape interval set to ", scrapeInterval)

go func() {
for ; true; <-time.NewTicker(scrapeInterval).C {
go fetchMetrics(metricsSet)
go fetchMetrics(metricsDenylist)
}
}()

Expand Down
Loading