chore: optimize react-simple-icons #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
deini
approved these changes
Feb 27, 2024
chanceaclark
force-pushed
the
chore/optimize-simple-icons
branch
from
dee3138 to
b7934c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Was running into this issue with
react-simple-iconsdue to them only exporting a barrel file. This causes some issues when the runtime tries to build a page and has to handle a ton of files (or large files) at once.Before this PR we have been bundling the full export of
@icons-pack/react-simple-icons. With a recent version of Next.js, it introduces an automagical way of optimizing the imports, cutting down bundle size. This PR cuts down that packages import size while fixing any future versions of the issue I ran into.