Upcoming changes to HTTP header casing #278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.bigcommerce.com/changelog#publications/upcoming-changes-to-http-header-casing For example, HTTP header names such as `X-Rate-Limit-Requests-Left` may instead be returned as `x-rate-limit-requests-left`. Per the HTTP specification (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2), HTTP header names should always be treated as case-insensitive, so we do not consider this to be a breaking change to the API.
|
This is already handled here by comparing the header names to the input header name case insensitively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For example, HTTP header names such as
X-Rate-Limit-Requests-Leftmay instead be returned asx-rate-limit-requests-left. Per the HTTP specification (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2), HTTP header names should always be treated as case-insensitive, so we do not consider this to be a breaking change to the API.Tickets / Documentation
Screenshots (if appropriate)