chore: Sync with template to include packaging #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: CI, lint and boilerplate
* [manifest-structure] - added manifest structure to template * Update README.md Co-authored-by: Anton Georgiev <[email protected]> --------- Co-authored-by: Anton Georgiev <[email protected]>
GuiLeme
reviewed
Feb 17, 2025
There was a problem hiding this comment.
LGTM! Just need to double check with @germanocaumo if those configurations are still necessary!
README.md
Outdated
| ``` | ||
|
|
||
| 2. Add this to the `settings.yml` of the BBB HTML5-client: | ||
| ```yaml |
There was a problem hiding this comment.
This portion seems to be core configuration of this plugin, it is not supposed to be taken off without being replaced with the newest version of this setting. @germanocaumo Could you take a look and see if it's still used in the plugin?
There was a problem hiding this comment.
Yes, it is still needed, to be able to configure the help links shown in the tour.
@antobinary
There was a problem hiding this comment.
Done! Thanks for the feedback!
GuiLeme
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes Issue(s)
Closes # none
Motivation
I was looking for using the packaging
More