-
Notifications
You must be signed in to change notification settings - Fork 190
chore: Add "serve" rule to Makefile and provide description to what actions available #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ctions are available by default make does nothing! I kept it that way but made that "nothing" explicit. I also added serve target so it is straightforward to trigger build&serve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Makefile by adding a user-friendly "serve" target and providing helpful descriptions of available make targets. The changes make it explicit that running make without arguments does nothing by default, while guiding users toward useful commands. The CONTRIBUTING.md documentation is updated to reflect the new make serve option.
Key Changes:
- Added a
servetarget to the Makefile that prepares the environment and runsmkdocs serve - Modified the default
alltarget to print helpful descriptions of available make targets - Updated CONTRIBUTING.md to document the new
make serveoption
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Added .PHONY declarations, implemented help text in the all target, and introduced a new serve target that depends on install |
| CONTRIBUTING.md | Updated build instructions to mention the new make serve command as an alternative to directly running uv run mkdocs serve |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
| @echo " serve -- prep environment and build and serve docs" | ||
| @echo " formatschema -- format and commit(!) schema" | ||
|
|
||
| serve: install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No javascript is needed.
| serve: install | |
| serve: .venv |
Co-authored-by: Copilot <[email protected]>
| ### 4. Ready to build! | ||
|
|
||
| Using the terminal (command line) please enter `uv run mkdocs serve`. | ||
| Using the terminal (command line) please enter `uv run mkdocs serve`. Alternatively, if you would like to use `make`, run `make serve` which will ensure the node and `uv` environments are present and trigger the `mkdocs` build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Using the terminal (command line) please enter `uv run mkdocs serve`. Alternatively, if you would like to use `make`, run `make serve` which will ensure the node and `uv` environments are present and trigger the `mkdocs` build. | |
| Using the terminal (command line) please enter `uv run mkdocs serve`. | |
| Alternatively, if you would like to use `make`, run `make serve`, which will run `uv sync` and then `mkdocs`. |
by default make does nothing! I kept it that way but made that "nothing" explicit. I also added serve target so it is straightforward to trigger build&serve