-
Notifications
You must be signed in to change notification settings - Fork 12
[WIP] refactor narrowing, add test, run narrow before copying #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| function BIDS = narrow_participants(BIDS, labels) | ||
| % NARROW_PARTICIPANTS - restrict BIDS struct to only requested labels | ||
| % | ||
|
|
||
| % nothing to do if no labels to change? | ||
| if isempty(labels) | ||
| return | ||
| end | ||
|
|
||
| idx = ismember({BIDS.subjects.name},labels); | ||
| BIDS.subjects = BIDS.subjects(idx); | ||
|
|
||
| idx = ismember(BIDS.participants.participant_id,labels); | ||
| for fn=fieldnames(BIDS.participants)' | ||
| replace = BIDS.participants.(char(fn)); | ||
| % BIDS.participants.meta is 1x1. other fields are 1xN | ||
| if(length(replace) < length(idx)) | ||
| warning('BIDS participants field "%s" too short: ID idx len %d > number of field values %d; ignored', ... | ||
| char(fn), length(idx), length(replace)) | ||
| continue | ||
| end | ||
| BIDS.participants.(char(fn)) = replace(idx); | ||
| end | ||
|
|
||
| end | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think you could rewrite this test to be used directly by matlab testing framework? Ideally with setup and teardown functions. https://nl.mathworks.com/help/matlab/matlab_prog/write-test-using-setup-and-teardown-functions.html If you don't have the bandwidth, let me know and I can give it a go |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| % | ||
| % script based testing for narrow_participants | ||
| % participants.json adds a 'meta' field that can be avoided when selecting only some participants | ||
| % | ||
|
|
||
| bids_dir = [tempname '_bids_test']; | ||
| try | ||
| % build minimal BIDS filesystem: participants.json and 1 anat file pair | ||
| system(['mkdir -p ' bids_dir '/sub-{a,b}/ses-{1,2}/anat/']); | ||
| system([ 'touch ' bids_dir '/sub-{a,b}/ses-{1,2}/anat/T1.{json,nii.gz}']); | ||
| system(['echo -e ''participant_id\nsub-a\nsub-a\nsub-b\nsub-b'' > ' bids_dir '/participants.tsv']); | ||
| system(['echo ''{ "Name": "test", "BIDSVersion": "1.4.1"}'' > ' bids_dir '/dataset_description.json']); | ||
| system(['echo ''{ "age": { "Description": "xyz" } }'' > ' bids_dir '/participants.json']); | ||
|
|
||
| % get what we built -- matches expectations | ||
| BIDS = spm_BIDS(bids_dir); | ||
| assert(length(BIDS.participants.participant_id) == 4) | ||
|
|
||
| % narrowing works | ||
| BIDS_narrow = narrow_participants(BIDS, {'sub-a'}) | ||
| assert(length(BIDS_narrow.participants.participant_id) == 2) | ||
|
|
||
| % no change on empty | ||
| BIDS_nochange = narrow_participants(BIDS, {}); % TODO: {{}}? | ||
| assert(length(BIDS_nochange.participants.participant_id) == 4) | ||
|
|
||
| catch me | ||
| rmdir(bids_dir,'s') | ||
| rethrow(me) | ||
| end |
Uh oh!
There was an error while loading. Please reload this page.