Skip to content

fix: skip settings on codeDiff if does not exisits #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakulstra merged 2 commits into from
Mar 17, 2026
Merged

fix: skip settings on codeDiff if does not exisits #26

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7118c2d
fix: skip settings on codeDiff if does not exisits
brotherlymite Mar 17, 2026
ab98db9
fix: add changeset
brotherlymite Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/tasks/code-diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function registerCodeDiff(program: Command) {
)
: parseEtherscanStyleSourceCode(sources[0].SourceCode);
const source2: StandardJsonInput = (
sources[0] as BlockscoutStyleSourceCode
sources[1] as BlockscoutStyleSourceCode
).AdditionalSources
? parseBlockscoutStyleSourceCode(
sources[1] as BlockscoutStyleSourceCode,
Expand Down
4 changes: 2 additions & 2 deletions packages/toolbox/src/operations/diffCode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ export async function diffCode(
) {
const changes: Record<string, string> = {};

// diff settings
// diff settings (skip if either source doesn't have settings, e.g. some explorers don't return it)
const settingsBefore = JSON.stringify(before.settings, null, 2);
const settingsAfter = JSON.stringify(after.settings, null, 2);
if (settingsBefore !== settingsAfter)
if (settingsBefore && settingsAfter && settingsBefore !== settingsAfter)
changes.settings = createPatch("settings", settingsBefore, settingsAfter);
const contractsBefore = await Promise.all(
Object.entries(before.sources).map(async ([path, source]) => [
Expand Down
Loading