Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-26
to
+45
| print("Looking for " + names[k] + "'s number") | ||
| print(f"Looking for {names[k]}" + "'s number") | ||
|
|
||
| # oracle construction | ||
| fdef = bin(k)[2:] | ||
| fdef = "0"*(n-len(fdef)) + fdef | ||
| g.def_oracle(fdef) | ||
| print("We are looking for " + fdef) | ||
| print(f"We are looking for {fdef}") | ||
|
|
||
| # running the algorithm | ||
| reg = g.run_iteration() | ||
| final = "" | ||
| for i in range(reg.nbits-1): | ||
| _, p = reg.get_qbit(i) | ||
| if p.state[0]>0.5: | ||
| final += '0' | ||
| else: | ||
| final += '1' | ||
| final += '0' if p.state[0]>0.5 else '1' | ||
| for i in range(reg.nbits): | ||
| print(reg.get_qbit(i)[0]) | ||
|
|
||
| # output of answers | ||
| print("Probably looking for : "+final) | ||
| print("Found Number: " + numbers[int(final,2)]) | ||
| print(f"Probably looking for : {final}") | ||
| print(f"Found Number: {numbers[int(final,2)]}") |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-43
to
+50
| target_state = int(base+"1",2) | ||
| target_state = int(f"{base}1", 2) | ||
| cmatrix[target_state,i_col] = 1 | ||
| target_state = int(base+"0",2) | ||
| cmatrix[target_state,i_col+1] = 1 | ||
| target_state = int(f"{base}0", 2) | ||
| else: | ||
| target_state = int(base+"0",2) | ||
| target_state = int(f"{base}0", 2) | ||
| cmatrix[target_state,i_col] = 1 | ||
| target_state = int(base+"1",2) | ||
| cmatrix[target_state,i_col+1] = 1 | ||
| target_state = int(f"{base}1", 2) | ||
| cmatrix[target_state,i_col+1] = 1 |
Author
There was a problem hiding this comment.
Function construct_unitary_F refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Comment on lines
-90
to
+92
| assert qreg.nbits == self.qreg_size, "This gate cannot be applied to register of size {}. Expected size: {}".format(qreg.nbits, self.qreg_size) | ||
| assert ( | ||
| qreg.nbits == self.qreg_size | ||
| ), f"This gate cannot be applied to register of size {qreg.nbits}. Expected size: {self.qreg_size}" | ||
|
|
Author
There was a problem hiding this comment.
Function Gate.apply refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
Comment on lines
-102
to
+104
| if isinstance(other, Sequence): | ||
| self.seq += other.seq | ||
| else: | ||
| self.seq += [other] | ||
| self.seq += other.seq if isinstance(other, Sequence) else [other] |
Author
There was a problem hiding this comment.
Function Sequence.add refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-214
to
+220
|
|
||
| self.matrix = matrix | ||
| self.msize = 2**len(qbpos) | ||
| self.qsize = 2**qreg_size | ||
| self.bases = np.arange(self.qsize) | ||
|
|
||
| self.qbpos = qbpos | ||
| self.specpos = list(filter(lambda x : not x in qbpos, range(qreg_size))) | ||
| self.specpos = list(filter(lambda x: x not in qbpos, range(qreg_size))) |
Author
There was a problem hiding this comment.
Function LazyGate.__init__ refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-46
to
+47
| for i in range(0,self.rowSize): | ||
| for j in range(0,that.colSize): | ||
| for i in range(self.rowSize): | ||
| for j in range(that.colSize): |
Author
There was a problem hiding this comment.
Function SparseMatrix.multiplySparseMatrix refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-68
to
+70
| new = SparseMatrix(matrix.shape[0],matrix.shape[1]) | ||
| for i in range(0,matrix.shape[0]): | ||
| for j in range(0,matrix.shape[1]): | ||
| new = SparseMatrix(matrix.shape[0],matrix.shape[1]) | ||
| for i in range(matrix.shape[0]): | ||
| for j in range(matrix.shape[1]): |
Author
There was a problem hiding this comment.
Function SparseMatrix.convertToSparse refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
|
|
||
| def scalarMultiply(self,scalar): | ||
| for i in range(0,len(self.elements)): | ||
| for i in range(len(self.elements)): |
Author
There was a problem hiding this comment.
Function SparseMatrix.scalarMultiply refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-83
to
+90
| for i in range(0,len(new.elements)): | ||
| for i in range(len(new.elements)): | ||
| new.elements[i].value = element.value*new.elements[i].value | ||
| cornerRow = element.rowIndex*that.rowSize | ||
| cornerCol = element.colIndex*that.colSize | ||
| for i in range (0,len(new.elements)): | ||
| for i in range(len(new.elements)): | ||
| new.elements[i].rowIndex += cornerRow | ||
| new.elements[i].colIndex += cornerCol | ||
| for element in new.elements: | ||
| new1.append(element) | ||
| new1.extend(iter(new.elements)) |
Author
There was a problem hiding this comment.
Function SparseMatrix.kronSparse refactored with the following changes:
- Simplify generator expression (
simplify-generator) - Replace range(0, x) with range(x) (
remove-zero-from-range) - Replace a for append loop with list extend (
for-append-to-extend)
Comment on lines
-21
to
+22
| for i in range(0,3): | ||
| for j in range(0,3): | ||
| for i in range(3): | ||
| for j in range(3): |
Author
There was a problem hiding this comment.
Function test_smatrix refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
Author
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.38%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!