Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for correct frame buffer output #119

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Add test for correct frame buffer output #119

merged 1 commit into from
Mar 2, 2018

Conversation

BenShelton
Copy link
Collaborator

This adds a new test to check that the frame buffer is actually generating the correct frames using the existing Croom.nes ROM. Some files will load and generate "frames" and a "frame rate" but will become stuck at the initial screen (a black border and grey box). This test helps to detect this issue (originally reported as #113)

This also fixes the file loading in the test cases to use binary instead of ascii encoding which causes the problem.

The test works by checking the first index of a certain color pixel (white) on the first 6 frames of output. Croom only uses 2 colors on the initial screen which makes it easy to detect. Comparing full snapshots of each frame takes too long.

@bfirsh
Copy link
Owner

bfirsh commented Mar 2, 2018

Super cool, thank you so much!

@bfirsh bfirsh merged commit 64b56a0 into bfirsh:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants