Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publication to Github Pages #373

Closed
wants to merge 211 commits into from
Closed

Conversation

ds17f
Copy link

@ds17f ds17f commented Aug 25, 2022

Updates the project to easily run on GitHub Pages. This is particularly useful for forks which might make changes (adding their own roms) and wish to present that to the world.

Adds a single command yarn run publish to push to gh-pages. I'm open to a different command as yarn publish is very different thing.

Major motivation was the ability to fork the project, change the config to show my rom, and then push it to the world for use.

FIXES: #371

ds17f added 30 commits May 6, 2017 12:16
This is a bit of a bodge, but stops most buffer underruns.
It doesn't work if there is no requestAnimationFrame
See bfirsh#15 for how this could be improved
ds17f added 25 commits April 21, 2020 14:03
Fixes bfirsh#221.

Some style changes as well as bootstrap class usage changes were
necessary in order to allow the drop zone to fill the height of the
screen.
Bumps [jsnes](https://github.com/bfirsh/jsnes) from `0ae34dd` to `96d028e`.
- [Release notes](https://github.com/bfirsh/jsnes/releases)
- [Commits](bfirsh/jsnes@0ae34dd...96d028e)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [jsnes](https://github.com/bfirsh/jsnes) from `96d028e` to `1cff0db`.
- [Release notes](https://github.com/bfirsh/jsnes/releases)
- [Commits](bfirsh/jsnes@96d028e...1cff0db)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.1 to 6.5.3. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.4.1...v6.5.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [jsnes](https://github.com/bfirsh/jsnes) from `1cff0db` to `1aac0c2`.
- [Release notes](https://github.com/bfirsh/jsnes/releases)
- [Commits](bfirsh/jsnes@1cff0db...1aac0c2)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.14.0. **This update includes security fixes.**
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@3.12.0...3.14.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [jsnes](https://github.com/bfirsh/jsnes) from `1aac0c2` to `ee248db`.
- [Release notes](https://github.com/bfirsh/jsnes/releases)
- [Commits](bfirsh/jsnes@1aac0c2...ee248db)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1. **This update includes a security fix.**
- [Release notes](https://github.com/sindresorhus/dot-prop/releases)
- [Commits](sindresorhus/dot-prop@v4.2.0...v4.2.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jsnes](https://github.com/bfirsh/jsnes) from `ee248db` to `9c40bd9`.
- [Release notes](https://github.com/bfirsh/jsnes/releases)
- [Commits](bfirsh/jsnes@ee248db...9c40bd9)

---
updated-dependencies:
- dependency-name: jsnes
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
This facilitates running on a site like github pages.

Setting the config.BASENAME will propagate through App and ListPages
@ds17f
Copy link
Author

ds17f commented Aug 25, 2022

Though this can be merged separately, I'd love to see #372 merge first, and then to update this PR to merge on top of #327. I wasn't able to change the base across forks and could only target master so I broke them into 2 separate PRs each of which stands on its own.

@ds17f ds17f closed this Aug 29, 2022
@ds17f ds17f force-pushed the publish-to-gh-pages branch from db018e6 to 89626af Compare August 29, 2022 13:45
@ds17f
Copy link
Author

ds17f commented Aug 29, 2022

Apologies, I messed up a name change on my commits. I'll reopen when I get it squared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems Publishing to Github Pages
1 participant