Skip to content

zWad general cleanup #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2025
Merged

zWad general cleanup #31

merged 6 commits into from
Nov 2, 2025

Conversation

@bluisblu
Copy link
Contributor

@bluisblu bluisblu commented Oct 23, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

⚠️ 🔥

+431 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 11

⚠️ main/SB/Game/zWad3 - .text -11 bytes -> 21.28%
⚠️ main/SB/Core/x/xWad2 - .sdata2 -3 bytes -> 5.01%
⚠️ main/SB/Core/x/xWad2 - .text -55 bytes -> 2.36%
⚠️ main/SB/Core/x/xWad3 - .sdata2 -13 bytes -> 29.73%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad3 - .text -8 bytes -> 5.66%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%
⚠️ main/SB/Game/zWad3 - zSurfaceGetSlideStopAngle(const xSurface*) -5 bytes -> 52.38%
⚠️ main/SB/Game/zWad3 - zSurfaceGetSlideStartAngle(const xSurface*) -5 bytes -> 57.14%
⚠️ main/SB/Core/x/xWad2 - xEntMotionInit(xEntMotion*, xEnt*, xEntMotionAsset*) -55 bytes -> 37.18%
⚠️ main/SB/Core/x/xWad3 - xDangleClamp(float) -8 bytes -> 81.82%

Progress: 12

📈 main/SB/Core/x/xWad3 - .text +11 bytes -> 16.14%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Core/x/xWad1 - .sdata2 +31 bytes -> 29.29%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%
📈 main/SB/Core/x/xWad3 - xMat3x3GetEuler(const xMat3x3*, xVec3*) +12 bytes -> 36.61%

@bluisblu bluisblu marked this pull request as draft October 23, 2025 23:43
@bluisblu
Add PI_DOUBLE separately for deg/rad macros
eee7ea1 
Hopefully undoes some regressions
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

⚠️ 🔥

+388 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 9

📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

⚠️ 🔥

+388 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 9

📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

⚠️ 🔥

+403 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 3

⚠️ main/SB/Core/x/xWad3 - .sdata2 -6 bytes -> 33.10%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 12

📈 main/SB/Core/x/xWad3 - .text +16 bytes -> 6.21%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%
✅ main/SB/Core/x/xWad3 - xDangleClamp(float) +7 bytes -> 100.00%
✅ main/SB/Core/x/xWad3 - xAngleClamp(float) +8 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

⚠️ 🔥

+403 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 4

⚠️ main/SB/Game/zWadUI - .sbss -24 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad3 - .sdata2 -6 bytes -> 33.10%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 12

📈 main/SB/Core/x/xWad3 - .text +16 bytes -> 6.21%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%
✅ main/SB/Core/x/xWad3 - xDangleClamp(float) +7 bytes -> 100.00%
✅ main/SB/Core/x/xWad3 - xAngleClamp(float) +8 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

⚠️ 🔥

+403 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 3

⚠️ main/SB/Core/x/xWad3 - .sdata2 -6 bytes -> 33.10%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 12

📈 main/SB/Core/x/xWad3 - .text +16 bytes -> 6.21%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zWad1 - .sbss +130 bytes -> 46.51%
📈 main/SB/Game/zWad3 - .sbss +95 bytes -> 69.23%
📈 main/SB/Core/x/xWad2 - .sbss +17 bytes -> 33.96%
📈 main/SB/Game/zWad1 - .sdata +119 bytes -> 45.83%
📈 main/SB/Game/zWad2 - .sdata +3 bytes -> 2.08%
📈 main/SB/Core/x/xWad4 - .sbss +10 bytes -> 54.24%
📈 main/SB/Game/zTalkBox - .sbss +6 bytes -> 20.00%
📈 main/SB/Game/zTaskBox - .sbss +8 bytes -> 50.00%
✅ main/SB/Core/x/xWad3 - xDangleClamp(float) +7 bytes -> 100.00%
✅ main/SB/Core/x/xWad3 - xAngleClamp(float) +8 bytes -> 100.00%

@bluisblu bluisblu marked this pull request as ready for review November 1, 2025 14:12
@LivewireCB LivewireCB merged commit a8054fe into bfbbdecomp:main Nov 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluisblu @LivewireCB