CI still runs on Rust 1.62

[joseph-gio]

What you did

In #5659, I made a change that relies on a fix in Rust 1.63.

What went wrong

CI fails. It's probably still running on Rust 1.62.

[TimJentzsch]

Hmmm, I'm a bit confused by the CI action here:

bevy/.github/workflows/ci.yml

Lines 15 to 39 in de6bef7

	build:
	strategy:
	matrix:
	os: [windows-latest, ubuntu-latest, macos-latest]
	runs-on: ${{ matrix.os }}
	steps:
	- uses: actions/checkout@v3
	- uses: actions/cache@v3
	with:
	path: |
	~/.cargo/bin/
	~/.cargo/registry/index/
	~/.cargo/registry/cache/
	~/.cargo/git/db/
	target/
	key: ${{ runner.os }}-cargo-build-stable-${{ hashFiles('**/Cargo.toml') }}
	- name: Install alsa and udev
	run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
	if: runner.os == 'linux'
	- name: Build & run tests
	# See tools/ci/src/main.rs for the commands this runs
	run: cargo run -p ci -- test
	env:
	CARGO_INCREMENTAL: 0
	RUSTFLAGS: "-C debuginfo=0 -D warnings"

Isn't this missing something like

- uses: actions-rs/toolchain@v1
  with:
    toolchain: stable
      components: rustfmt, clippy
      override: true

as the other CI jobs?
Maybe it's taking the old Rust version from the cache.

[mockersf]

if not changed by the toolchain action, it's taking Rust version from the one installed by default: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools
GitHub will probably update it soon but they didn't push the change on Friday 🤷

[joseph-gio]

it's taking Rust version from the one installed by default: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#rust-tools

Thanks for the pointer. Seems like the next release is scheduled for August 15.

[TimJentzsch]

Should we wait or use the toolchain action for the build job as well?

[mockersf]

Should we wait or use the toolchain action for the build job as well?

Yes, it seems we already uses it in most other jobs, it would make sense to use it here also 👍