Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary lint #12968

Closed
BD103 opened this issue Apr 15, 2024 · 0 comments · Fixed by #12983
Closed

Remove unecessary lint #12968

BD103 opened this issue Apr 15, 2024 · 0 comments · Fixed by #12983
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@BD103
Copy link
Member

BD103 commented Apr 15, 2024

rust-lang/rust#123905 has been merged, which fixes a bug I raised in rust-lang/rust#123677. In #12913 I created a temporary fix which adds #[allow(rustdoc::redundant_explicit_links)] to silence the bug. This can now be removed.

#[allow(rustdoc::redundant_explicit_links)]

When creating the PR, please check with the latest beta Rust that the error no longer occurs. It should be added to the beta channel, but it might not have been updated yet.

To test, run the following after removing the #[allow]:

cargo +beta doc -p bevy_winit --no-deps
@BD103 BD103 added A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy labels Apr 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2024
# Objective

- rust-lang/rust#123905 has been merged, so the
workaround introduced in #12913 is no longer necessary.
- Closes #12968

## Solution

- Remove unecessary `allow` attribute
  - This is currently blocked until Rust beta updates.
  - Last tested with `rustc 1.78.0-beta.7 (6fd191292 2024-04-12)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant