Skip to content

Commit b027d40

Browse files
committed
Update Box vertices comment (#7055)
Old comment is Z-up , Fix comment for bevy Y-up # Objective - Update Box vertices comment for bevy Y-up ## Solution - Update comment for Y-up --- ## Changelog None ## Migration Guide None
1 parent d296326 commit b027d40

File tree

1 file changed

+9
-8
lines changed
  • crates/bevy_render/src/mesh/shape

1 file changed

+9
-8
lines changed

crates/bevy_render/src/mesh/shape/mod.rs

+9-8
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,14 @@ impl Default for Box {
7373

7474
impl From<Box> for Mesh {
7575
fn from(sp: Box) -> Self {
76+
// suppose Y-up right hand, and camera look from +z to -z
7677
let vertices = &[
77-
// Top
78+
// Front
7879
([sp.min_x, sp.min_y, sp.max_z], [0., 0., 1.0], [0., 0.]),
7980
([sp.max_x, sp.min_y, sp.max_z], [0., 0., 1.0], [1.0, 0.]),
8081
([sp.max_x, sp.max_y, sp.max_z], [0., 0., 1.0], [1.0, 1.0]),
8182
([sp.min_x, sp.max_y, sp.max_z], [0., 0., 1.0], [0., 1.0]),
82-
// Bottom
83+
// Back
8384
([sp.min_x, sp.max_y, sp.min_z], [0., 0., -1.0], [1.0, 0.]),
8485
([sp.max_x, sp.max_y, sp.min_z], [0., 0., -1.0], [0., 0.]),
8586
([sp.max_x, sp.min_y, sp.min_z], [0., 0., -1.0], [0., 1.0]),
@@ -94,12 +95,12 @@ impl From<Box> for Mesh {
9495
([sp.min_x, sp.max_y, sp.max_z], [-1.0, 0., 0.], [0., 0.]),
9596
([sp.min_x, sp.max_y, sp.min_z], [-1.0, 0., 0.], [0., 1.0]),
9697
([sp.min_x, sp.min_y, sp.min_z], [-1.0, 0., 0.], [1.0, 1.0]),
97-
// Front
98+
// Top
9899
([sp.max_x, sp.max_y, sp.min_z], [0., 1.0, 0.], [1.0, 0.]),
99100
([sp.min_x, sp.max_y, sp.min_z], [0., 1.0, 0.], [0., 0.]),
100101
([sp.min_x, sp.max_y, sp.max_z], [0., 1.0, 0.], [0., 1.0]),
101102
([sp.max_x, sp.max_y, sp.max_z], [0., 1.0, 0.], [1.0, 1.0]),
102-
// Back
103+
// Bottom
103104
([sp.max_x, sp.min_y, sp.max_z], [0., -1.0, 0.], [0., 0.]),
104105
([sp.min_x, sp.min_y, sp.max_z], [0., -1.0, 0.], [1.0, 0.]),
105106
([sp.min_x, sp.min_y, sp.min_z], [0., -1.0, 0.], [1.0, 1.0]),
@@ -111,12 +112,12 @@ impl From<Box> for Mesh {
111112
let uvs: Vec<_> = vertices.iter().map(|(_, _, uv)| *uv).collect();
112113

113114
let indices = Indices::U32(vec![
114-
0, 1, 2, 2, 3, 0, // top
115-
4, 5, 6, 6, 7, 4, // bottom
115+
0, 1, 2, 2, 3, 0, // front
116+
4, 5, 6, 6, 7, 4, // back
116117
8, 9, 10, 10, 11, 8, // right
117118
12, 13, 14, 14, 15, 12, // left
118-
16, 17, 18, 18, 19, 16, // front
119-
20, 21, 22, 22, 23, 20, // back
119+
16, 17, 18, 18, 19, 16, // top
120+
20, 21, 22, 22, 23, 20, // bottom
120121
]);
121122

122123
let mut mesh = Mesh::new(PrimitiveTopology::TriangleList);

0 commit comments

Comments
 (0)