Import des Déclarations historiques de TeleIcare dans le modèle de Déclarations #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 23, 2024 18:08
…nable creation with less mandatory fields
hfroot
approved these changes
Jan 8, 2025
| warning=latest_ica_version_declaration.vrsdecl_mise_en_garde | ||
| if latest_ica_version_declaration.vrsdecl_mise_en_garde | ||
| else "", | ||
| # TODO: ces champs proviennent de tables pas encore importées |
There was a problem hiding this comment.
oui dans une prochaine PR
|
|
||
| etablissement_to_create_as_company = EtablissementFactory(etab_siret=None, etab_ica_importateur=True) | ||
| # ne sera pas créé car le numéro de téléphone est mal formatté | ||
| _ = EtablissementFactory(etab_siret=None, etab_ica_importateur=True, etab_telephone="0345") |
pletelli
commented
Jan 9, 2025
alemangui
approved these changes
Jan 9, 2025
pletelli
commented
Jan 9, 2025
| @@ -83,7 +86,7 @@ class Meta: | |||
| verbose_name = "entreprise" | |||
|
|
|||
| social_name = models.CharField("dénomination sociale") | |||
| commercial_name = models.CharField("enseigne", help_text="nom commercial") | |||
| commercial_name = models.CharField("enseigne", blank=True, help_text="nom commercial") | |||
| # null=True permet de gérer en parralèle le unique=True | |||
| siret = models.CharField( | |||
| "n° SIRET", | |||
There was a problem hiding this comment.
Relâcher la contrainte company blank=False
There was a problem hiding this comment.
Est-ce qu'on veut une creation_date dans Company ?
| * télédéclarante de la déclaration (cette relation n'est pour le moment pas conservée, car le BEPIAS ne sait pas ce qu'elle signifie) | ||
| """ | ||
| nb_created_declarations = 0 | ||
| for ica_complement_alimentaire in IcaComplementAlimentaire.objects.all(): |
There was a problem hiding this comment.
Documenter les 3 tables
| self.assertEqual(created_company.siccrf_id, etablissement_to_create_as_company.etab_ident) | ||
| self.assertEqual(created_company.address, etablissement_to_create_as_company.etab_adre_voie) | ||
| self.assertEqual(created_company.postal_code, etablissement_to_create_as_company.etab_adre_cp) | ||
| self.assertEqual(created_company.city, etablissement_to_create_as_company.etab_adre_ville) |
There was a problem hiding this comment.
Ajouter des tests sur les créations de Declarations
added 2 commits
January 9, 2025 17:49
…n email is mandatory
|
Je merge sans le test sur la création des déclarations, car ça ajoute beaucoup de code (avec les factories notamment), mais avec le changement sur les PhoneNumberField |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717
Cette PR propose :
la création des Company qui viennent de Teleicare mais n'existeraient pas déjà dans le système Compl'Alim. Le but est de pouvoir intégrer toutes les données possibles aux modèles compl'Alim, notamment pour que les export OpenData soient plus simples (au risque d'augmenter un peu le volume de données stockées)
match_companies_on_siret_or_vat(create_if_not_exist=True)commercial_nameetemailpour accepter "" : en front ces champs sont toujours required. Nous avions déjà commencé à questionner la nécessité du champcommercial_namevssocial_namevsmarquevsgamme-> je suis preneuse d'avis sur ce choixmatchedest ajouté au model Company pour permettre de retrouver :Ajout d'une fonction de création des Declarations
TODO after merge :