Désactivation du bouton de décision lors que la requête est en cours #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemangui
changed the title
pletelli
approved these changes
Jan 7, 2025
| @@ -43,7 +43,7 @@ const snapshots = computed(() => { | |||
| }) | |||
|
|
|||
| const showOnRight = (snapshot) => { | |||
| const rightSideStatus = ["OBSERVATION", "AUTHORIZED", "AWAITING_VISA"] | |||
| const rightSideStatus = ["OBSERVATION", "AUTHORIZED", "AWAITING_VISA", "OBJECTION"] | |||
There was a problem hiding this comment.
Merci ! justement je l'avais vu comme bug hier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1384
Contexte
Dans Sentry nous avons trouvé quelques
TransactionNotAllowedqui semblent être liés à des requêtes répétées pour un changement de statut de la déclaration.Scope
La UI a en effet un bug dans l'étape de décision de l'instruction ainsi que l'étape de validation de la viseuse : le bouton n'est pas désactivé lors que la requête est en cours.
Pour y remédier on peut utiliser le
isFetchingde useFetch . Une alternative que je n'ai pas choisi (même si elle est tout à fait correcte aussi) serait d'utiliser un boolean comme on le fait pour la soumission côté pro.Pour utiliser le
isFetchingcomme ref général utilisable dans le template, j'ai du sortir les appels à useFetch hors la fonction qui les utilisait - d'où le refactoring à ce niveau là.Démo
Côté instruction (en ralentissant exprès la requête) :
Screencast.from.2024-12-23.13-11-12.mp4
Côté visa (aussi avec une requête ralentie) :
Screencast.from.2024-12-23.13-13-14.mp4