[refactor] lexical scoping

[haslinghuis]

TBD

[McGiverGim]

There is no way way to fix this without returning to the old var?

[nerdCopter]

a585376f no change in behavior for me (still Cannot plot analyser TypeError: Cannot read properties of undefined (reading '0') for Freq vs Throttle).

[tbolin]

I don't think the variable scopes are the problem. There is a possibility that 'vsBinIndex' is 100, which cause an out of bounds array access on line 124 in graph_spectrum_calc.js

[nerdCopter]

i put line 124 inside of try/catch and yes, many errors. graph rendered successfully.

(reading 200..299) on my log. 0..599 on the test 1.txt log.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[nerdCopter]

close this in favor of merged #693 correct?

[haslinghuis]

Wanted to apply lexical scoping instead.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

[github-actions]

Pull request closed automatically as inactive.