Fixes #691 Prevent out of bounds access when ploting Throttle vs Freq…

…uency (#693) Prevent out of bounds access when ploting Throttle vs Frequency
betaflight · Jan 23, 2024 · a11ed06 · a11ed06
1 parent bfd5ab7
commit a11ed06
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/js/graph_spectrum_calc.js b/js/graph_spectrum_calc.js
@@ -116,7 +116,9 @@ GraphSpectrumCalc._dataLoadFrequencyVsX = function(vsFieldNames, minValue = Infi
             }
             // Translate the average vs value to a bin index
             const avgVsValue = sumVsValues / fftChunkLength;
-            const vsBinIndex = Math.floor(NUM_VS_BINS * (avgVsValue - flightSamples.minValue) / (flightSamples.maxValue - flightSamples.minValue));
+            let vsBinIndex = Math.floor(NUM_VS_BINS * (avgVsValue - flightSamples.minValue) / (flightSamples.maxValue - flightSamples.minValue));
+            // ensure that avgVsValue == flightSamples.maxValue does not result in an out of bounds access
+            if (vsBinIndex === NUM_VS_BINS) { vsBinIndex = NUM_VS_BINS - 1; }
             numberSamples[vsBinIndex]++;
 
             // add the output from the fft to the row given by the vs value bin index