Skip to content

Add support for smix reverse #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add support for smix reverse #4388

wants to merge 2 commits into from

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 11.0 milestone Mar 15, 2025
@haslinghuis haslinghuis self-assigned this Mar 15, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 15, 2025 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit cb37527
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/67d739c44813890008a20909
😎 Deploy Preview https://deploy-preview-4388.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis mentioned this pull request Mar 15, 2025
Closed
@limonspb
Copy link
Member

limonspb commented Mar 16, 2025 •
edited
Loading

@haslinghuis i don't quite understand how this works.. is that the same as CLI smix reverse <servo> <source> r|n?
But then where is "source" in UI, or is it applying to all sources?

@haslinghuis haslinghuis marked this pull request as draft March 16, 2025 14:20
@haslinghuis
Copy link
Member Author

haslinghuis commented Mar 16, 2025 •
edited
Loading

@limonspb

  • probably wrongly assumed reverse was applied on the servo level
  • looks like reverse applies to any input on a servo - a bit confusing as you expect a channel being set before able to use smix reverse.
  • Also MSP_SERVO_MIX_RULES and MSP_SET_SERVO_MIX_RULES is not implemented.

https://betaflight.com/docs/development/Mixer#smix-reverse

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.6 Release
Status: App
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@haslinghuis @limonspb