Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define webpack publicPath #173

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Define webpack publicPath #173

merged 1 commit into from
Sep 8, 2021

Conversation

0leksandr
Copy link
Contributor

@0leksandr 0leksandr commented Sep 8, 2021

This commit fixes the webpack error "Automatic publicPath is not supported in this browser", which I catch in browser Vivaldi 3.6.2165.3 for Ubuntu 64bit (based on Chromium), and which breaks the extension in this browser (although it worked well at least before September 2021).

The solution is copied from the documentation: https://webpack.js.org/guides/public-path/
I have also tried option publicPath: 'auto' from the documentation, but it did not work (the extension was broken, like before)

@berzniz
Copy link
Owner

berzniz commented Sep 8, 2021

Thanks @0leksandr - is this verified on a GitHub enterprise account or a regular account?

@0leksandr
Copy link
Contributor Author

0leksandr commented Sep 8, 2021

@berzniz, I made it from my personal (regular) account. It is connected to an organization, but that is not related to this PR

@halfbro
Copy link

halfbro commented Sep 8, 2021

I just tested 0leksandr's branch for my company's internal Github Enterprise - the extension works now whereas before I was getting the publicPath error.

e: Using Chrome 92.0.4515.159

@berzniz berzniz merged commit 788187f into berzniz:master Sep 8, 2021
@0leksandr 0leksandr deleted the define-webpack-public-path branch September 9, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants