Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle comments button #116

Closed
wants to merge 1 commit into from
Closed

Add toggle comments button #116

wants to merge 1 commit into from

Conversation

wd
Copy link

@wd wd commented May 5, 2020

Related issue #114

Add a button that can toggle all comments show/hide.

image

After hide comments, here will append an icon to notify user.

image

I think it's enough for my daily use, but there are still some improvements could be done:

  1. Add click event to the appended icon, so that user can show/hide the comment through click.
  2. The click event should connected with the click event from the original show comments menu.

} else {
const span = document.createElement('span')
span.className = appendIconClassName
const svg = '<svg className="octicon" xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">' +
Copy link
Author

@wd wd May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test inline comments.

@wd wd closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant