Use Github's sort order #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing sorting method uses a couple of heuristics to sort - however, there are cases where the resulting sorting does not match the order in which Github displays the files. As a result, scrolling down the list can cause the selected file in the tree to jump around rather than going down one-by-one. This commit removes most of the sorting logic and instead uses the index of the name of the file on the page, guaranteeing the tree matches Github even if they change their ordering logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing sorting method uses a couple of heuristics to sort -
however, there are cases where the resulting sorting does not match
the order in which Github displays the files.
As a result, scrolling down the list can cause the selected file in the
tree to jump around rather than going down one-by-one.
This commit removes most of the sorting logic and instead uses the index
of the name of the file on the page, guaranteeing the tree matches
Github even if they change their ordering logic.
Fixes #187