Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort order in tree structure does not match sort order in GitHub list #187

Open
richellis opened this issue Dec 2, 2021 · 3 comments
Open
Labels
help wanted Extra attention is needed

Comments

@richellis
Copy link

GitHub displays files in a folder before files in a subfolder, the tree view shows the subfolders first. Example:

GitHub

Sources/Webservice/ProductFeedWebservice.swift
Sources/Webservice/Request/ProductFeedRequest.swift

Tree view

Sources/Webservice/Request/ProductFeedRequest.swift
Sources/Webservice/ProductFeedWebservice.swift

It's really confusing to me to be navigating the tree and having the GitHub display jump all around in a different order. If the current tree view sort order is an intentional feature (folders before files), consider an option to match the GitHub listing order?

@berzniz
Copy link
Owner

berzniz commented Jan 7, 2022

I'd accept a PR that:

  1. Adds the feature of displaying in the same GitHub file order
  2. The feature is optional and turned off by default (configured from the options page)

@berzniz berzniz added the help wanted Extra attention is needed label Jan 7, 2022
@jgilchrist
Copy link

I've filed #201 for this - as it stands I didn't implement (2.) because it seemed straightforward to have the tree just always mirror the PR.

@joelpryde
Copy link

This would make the plugin immensely less confusing. Is there any reason why it isn't the default that the two views have the same order?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants