Skip to content

Add explicit selector to input so getValue can get the correct element #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zamakkat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add explicit selector to input so getValue can get the correct element #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/assets/javascripts/best_in_place.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ BestInPlaceEditor.forms = {
.attr('action', 'javascript:void(0);')
.attr('style', 'display:inline');
var input_elt = jQuery(document.createElement('input'))
.addClass('input_in_place')
.attr('type', 'text')
.attr('name', this.attributeName)
.val(this.display_value);
Expand Down Expand Up @@ -401,7 +402,7 @@ BestInPlaceEditor.forms = {

getValue: function () {
'use strict';
return this.sanitizeValue(this.element.find("input").val());
return this.sanitizeValue(this.element.find("input.input_in_place").val());
},

// When buttons are present, use a timer on the blur event to give precedence to clicks
Expand Down Expand Up @@ -660,6 +661,3 @@ jQuery.fn.best_in_place = function () {

return this;
};